Past Paid Bounties

Past paid bounties

This list includes valid submissions from past and current contract versions for which a bounty has been paid.

Potential suicide of MultiSend library

We use a MultiSend (opens in a new tab) library to batch multiple transactions together. A transaction could be created that would self-destruct the contract. While this would not have put any funds at risk, user experience would have been seriously impacted.

We've updated the library as well as our interfaces. Details about the fix can be found on GitHub (opens in a new tab).

This bug was submitted by Micah Zoltu (opens in a new tab). It was regarded as a "Low Threat," and a bounty of 1,000 USD has been paid out.

Transaction failure when receiving funds via transfer or send

Since the beginning of the bug bounty period, the contract update has been live on the Ethereum Mainnet. We performed extensive internal testing and discovered an edge case where a Safe couldn't receive funds from another contract via send or transfer. This was due to additional gas costs caused by the emission of additional events (opens in a new tab) and gas price changes (opens in a new tab) in the latest hard fork. This issue has been fixed, and more details can be found on GitHub (opens in a new tab).

Duplicate owners during setup could render Safe unusable

A bug in the setupOwners function on OwnerManager.sol allows duplicate owners to be set when the duplicated address is next to itself in the _owners array. This could cause unexpected behavior. While stealing funds from existing Safes is impossible, it's unexpected, and user funds might be locked. During Safe creation, the threshold of a Safe could be set to something unreachable, making it impossible to execute a transaction afterward.

The Safe interfaces prevent this by checking for duplicates, but if users directly interact with the contracts, this can still happen. The issue is tracked on GitHub (opens in a new tab).

This bug was submitted by David Nicholas (opens in a new tab). It was regarded as a "Medium Threat," and a bounty of 2,500 USD has been paid out.

Setting a Safe as an owner of itself essentially reduces the threshold by 1

The contracts allow to set a Safe as an owner of itself. This has the same effect as lowering the threshold by 1, as it's possible for anyone to generate a valid signature for the Safe itself when triggering execTransaction. This is especially an issue for Safes with a threshold of 1. Anyone can execute transactions if a Safe with threshold 1 adds itself as an owner.

To our knowledge, there is no actual use case where it would make sense to set a Safe as an owner of itself. Hence, only a few number of Safes used themselves as owners. Most of these Safes could be contacted, and the Safe has been removed as an owner. The Safes still affected are Safes used for testing by us or Safes owned by a single owner with a threshold > 1 (so no immediate risk).

To fix this, the next contract update will prevent the Safe as its owner via require(owner != address(this), "Safe can't be an owner"). This check can be performed when adding owners and/or when checking signatures.

Details about this issue can be found on GitHub (opens in a new tab).

The bug was submitted by Kevin Foesenek (opens in a new tab). It was regarded as a "Medium Threat," and a bounty of 5,000 USD has been paid out.

The function getModulesPaginated doesn't return all modules

The method getModuledPaginated (opens in a new tab) is used to return enabled modules page by page. For this, a start and a pageSize need to be specified, and the method will return an array of Safe Module addresses and next. This next can be used as the start to load the next page. When another page exists, then next is a module address. This module address, however, won't be present in any of the returned arrays. While this doesn't put any user assets at risk directly, it could lead to a wrong perception of the enabled modules of a Safe and, thereby, its state.

The workaround is to append the next to the returned array of module addresses if it's not the zero or sentinel address. Alternatively, the last element of the returned array can be used as the start for the next page.

This bug was submitted by Renan Souza (opens in a new tab). It was regarded as a "Low Threat," and a bounty of 2,000 USD has been paid out.

Signature verification does not enforce a maximum size on the signature bytes

The function checkNSignatures (opens in a new tab) does not enforce a size limit on the signature bytes. This means that they can be padded with arbitrary data. This can be used by manipulating the signatures by padding them with additional data while remaining valid and, since the signatures bytes get copied from calldata into memory, increase the total gas consumption of the checkNSignatures function. This is an issue when the Safe is combined with the ERC-4337 module (opens in a new tab), where the account pays the gas costs for the ERC-4337 user operation. A malicious relayer can grief the account by padding the signatures bytes to include extra 0s, causing the account to pay more fees than it would have with optimally encoded signatures bytes.

The workaround is to set a strict verificationGasLimit for ERC-4337 user operations. This would set a strict upper bound on how much gas can be paid during signature verification and limit the potential additional fees.

This bug was submitted by Adam Egyed (opens in a new tab). It was regarded as a "Low Threat," and a bounty of 1,000 USD has been paid out.

Was this page helpful?